Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 2878045: Revert 52408 - Remove images on disk that are not referenced by anything.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by rohitrao (OOO until 6-22)
Modified:
4 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Bring back find_next_Template.pdf and find_prev_Template.pdf. This CL partially reverts r52408 - Remove images on disk that are not referenced by anything. BUG=49572 TEST=Find bar buttons should show up again on mac. Review URL: http://codereview.chromium.org/2986006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A + chrome/app/theme/find_next_Template.pdf View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/find_prev_Template.pdf View 0 chunks +-1 lines, --1 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
rohitrao (OOO until 6-22)
4 years, 10 months ago (2010-07-21 22:29:54 UTC) #1
Robert Sesek
LGTM. You should update the unit test to DCHECK both buttons' image.
4 years, 10 months ago (2010-07-21 22:49:19 UTC) #2
Peter Kasting
How is it that chrome_dll.gypi never had these in the list where the other xxx_Template.pdf ...
4 years, 10 months ago (2010-07-21 23:21:36 UTC) #3
rohitrao (OOO until 6-22)
Looks like they used to be in the list but got pulled out in r52409. ...
4 years, 10 months ago (2010-07-22 00:25:40 UTC) #4
Peter Kasting
On 2010/07/22 00:25:40, rohitrao wrote: > Looks like they used to be in the list ...
4 years, 10 months ago (2010-07-22 01:13:16 UTC) #5
rohitrao (OOO until 6-22)
4 years, 10 months ago (2010-07-22 01:47:55 UTC) #6
Next time don't use
> drover, just grab the icons off the svn browser (you can download any version
> controlled resource from any version number) and re-add them.

Hott, I didn't know you could do that.  My other reason for reverting was to get
all of the svn properties right.  Probably the best solution would've been to
run drover, copy/paste the resulting "svn merge" commands into a local client,
then make the other changes and submit all at one.  Next time =(
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be