Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2878014: [Isolates] Fixing Win32 compile and running tests failure. (Closed)

Created:
10 years, 5 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Fixing Win32 compile and running tests failure. Landing patch by Maxim.Mossienko with minor changes in candidate version handling. Original review: http://codereview.chromium.org/2844034/show Committed: http://code.google.com/p/v8/source/detail?r=4982

Patch Set 1 #

Patch Set 2 : Typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/ast.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698