|
|
Revert 50902 - New HTML Sync Setup UI.
Was reverted because of a valgrind error. This is try #2.
Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.
New flow:
- type username/password. wait for Gaia auth. (with throbber)
- error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.
Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings. Not final yet, I don't think.
BUG= 45869
TEST=Exercise all the different paths through the login flow.
Review URL: http://codereview.chromium.org/2880001
TBR=dantasse@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51167
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+160 lines, -502 lines) |
Patch |
 |
M |
chrome/browser/sync/glue/sync_backend_host.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service.h
|
View
|
|
3 chunks |
+5 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service.cc
|
View
|
|
4 chunks |
+4 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/resources/choose_datatypes.html
|
View
|
|
6 chunks |
+7 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/resources/gaia_login.html
|
View
|
|
9 chunks |
+115 lines, -106 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/resources/setup_flow.html
|
View
|
|
1 chunk |
+4 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/sync_setup_flow.h
|
View
|
|
3 chunks |
+0 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/sync_setup_flow.cc
|
View
|
|
12 chunks |
+5 lines, -168 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/sync_setup_wizard.h
|
View
|
|
2 chunks |
+6 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/sync_setup_wizard.cc
|
View
|
|
2 chunks |
+2 lines, -43 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/sync_setup_wizard_unittest.cc
|
View
|
|
8 chunks |
+4 lines, -61 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/syncable/model_type.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/views/options/content_page_view.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/common/pref_names.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/common/pref_names.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/common/url_constants.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/common/url_constants.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
2878012:
Revert 50902 - New HTML Sync Setup UI.... (Closed)
