build/vs_toolchain.py - Issue 2877993002: Changing default Windows compiler to VS2017

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 2877993002: Changing default Windows compiler to VS2017 (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 0ff51815212da7198fc521eedaf1f45ffefe5cd6..67a3776c43ebd1af77396c7a29669d79702efbe9 100755

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -22,8 +22,8 @@ sys.path.insert(0, os.path.join(chrome_src, 'tools', 'gyp', 'pylib'))

json_data_file = os.path.join(script_dir, 'win_toolchain.json')

-# Use MSVS2015 as the default toolchain.

-CURRENT_DEFAULT_TOOLCHAIN_VERSION = '2015'

+# Use MSVS2017 as the default toolchain.

+CURRENT_DEFAULT_TOOLCHAIN_VERSION = '2017'

def SetEnvironmentAndGetRuntimeDllDirs():

« no previous file with comments | « no previous file | no next file » | no next file with comments »