Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2877893003: DevTools: Show product name when available in group by [sub]domain mode. (Closed)
Patch Set: update test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @unrestricted 6 * @unrestricted
7 * @implements {UI.Searchable} 7 * @implements {UI.Searchable}
8 */ 8 */
9 Timeline.TimelineTreeView = class extends UI.VBox { 9 Timeline.TimelineTreeView = class extends UI.VBox {
10 constructor() { 10 constructor() {
(...skipping 676 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 name = this._executionContextNamesByOrigin.get(name) || name; 687 name = this._executionContextNamesByOrigin.get(name) || name;
688 return name; 688 return name;
689 } 689 }
690 switch (this._groupBySetting.get()) { 690 switch (this._groupBySetting.get()) {
691 case Timeline.AggregatedTimelineTreeView.GroupBy.Category: 691 case Timeline.AggregatedTimelineTreeView.GroupBy.Category:
692 var category = categories[node.id] || categories['other']; 692 var category = categories[node.id] || categories['other'];
693 return {name: category.title, color: category.color}; 693 return {name: category.title, color: category.color};
694 694
695 case Timeline.AggregatedTimelineTreeView.GroupBy.Domain: 695 case Timeline.AggregatedTimelineTreeView.GroupBy.Domain:
696 case Timeline.AggregatedTimelineTreeView.GroupBy.Subdomain: 696 case Timeline.AggregatedTimelineTreeView.GroupBy.Subdomain:
697 return {name: beautifyDomainName.call(this, node.id) || unattributed, co lor: color}; 697 var domainName = beautifyDomainName.call(this, node.id);
698 if (domainName) {
699 var productName = this._productByEvent(/** @type {!SDK.TracingModel.Ev ent} */ (node.event));
700 if (productName)
701 domainName += ' \u2014 ' + productName;
702 }
703 return {name: domainName || unattributed, color: color};
698 704
699 case Timeline.AggregatedTimelineTreeView.GroupBy.EventName: 705 case Timeline.AggregatedTimelineTreeView.GroupBy.EventName:
700 var name = node.event.name === TimelineModel.TimelineModel.RecordType.JS Frame ? 706 var name = node.event.name === TimelineModel.TimelineModel.RecordType.JS Frame ?
701 Common.UIString('JavaScript') : 707 Common.UIString('JavaScript') :
702 Timeline.TimelineUIUtils.eventTitle(node.event); 708 Timeline.TimelineUIUtils.eventTitle(node.event);
703 return { 709 return {
704 name: name, 710 name: name,
705 color: node.event.name === TimelineModel.TimelineModel.RecordType.JSFr ame ? 711 color: node.event.name === TimelineModel.TimelineModel.RecordType.JSFr ame ?
706 Timeline.TimelineUIUtils.eventStyle(node.event).category.color : 712 Timeline.TimelineUIUtils.eventStyle(node.event).category.color :
707 color 713 color
708 }; 714 };
709 715
710 case Timeline.AggregatedTimelineTreeView.GroupBy.Product: 716 case Timeline.AggregatedTimelineTreeView.GroupBy.Product:
711 var productName = this._productByEvent(/** @type {!SDK.TracingModel.Even t} */ (node.event)); 717 var productName = this._productByEvent(/** @type {!SDK.TracingModel.Even t} */ (node.event));
712 color = productName ? Timeline.TimelineUIUtils.colorForId(productName) : '#eee'; 718 color = productName ? Timeline.TimelineUIUtils.colorForId(productName) : '#eee';
713 var name = productName || this._domainByEvent(true, /** @type {!SDK.Trac ingModel.Event} */ (node.event)) || ''; 719 var name = productName || this._domainByEvent(true, /** @type {!SDK.Trac ingModel.Event} */ (node.event)) || '';
714 return {name: beautifyDomainName.call(this, name) || unattributed, color : color}; 720 return {name: beautifyDomainName.call(this, name) || unattributed, color : color};
715 721
716 case Timeline.AggregatedTimelineTreeView.GroupBy.URL: 722 case Timeline.AggregatedTimelineTreeView.GroupBy.URL:
717 break; 723 break;
718 724
719 case Timeline.AggregatedTimelineTreeView.GroupBy.Frame: 725 case Timeline.AggregatedTimelineTreeView.GroupBy.Frame:
720 var frame = this._model.timelineModel().pageFrameById(node.id); 726 var frame = this._model.timelineModel().pageFrameById(node.id);
721 var frameName = frame ? Timeline.TimelineUIUtils.displayNameForFrame(fra me, 80) : Common.UIString('Page'); 727 var frameName = frame ? Timeline.TimelineUIUtils.displayNameForFrame(fra me, 80) : Common.UIString('Page');
722 return {name: frameName, color: color}; 728 return {name: frameName, color: color};
723 729
724 default: 730 default:
725 console.assert(false, 'Unexpected aggregation type'); 731 console.assert(false, 'Unexpected grouping type');
726 } 732 }
727 return {name: node.id || unattributed, color: color}; 733 return {name: node.id || unattributed, color: color};
728 } 734 }
729 735
730 /** 736 /**
731 * @override 737 * @override
732 * @param {!UI.Toolbar} toolbar 738 * @param {!UI.Toolbar} toolbar
733 */ 739 */
734 populateToolbar(toolbar) { 740 populateToolbar(toolbar) {
735 super.populateToolbar(toolbar); 741 super.populateToolbar(toolbar);
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 1013
1008 _onSelectionChanged() { 1014 _onSelectionChanged() {
1009 this.dispatchEventToListeners(Timeline.TimelineStackView.Events.SelectionCha nged); 1015 this.dispatchEventToListeners(Timeline.TimelineStackView.Events.SelectionCha nged);
1010 } 1016 }
1011 }; 1017 };
1012 1018
1013 /** @enum {symbol} */ 1019 /** @enum {symbol} */
1014 Timeline.TimelineStackView.Events = { 1020 Timeline.TimelineStackView.Events = {
1015 SelectionChanged: Symbol('SelectionChanged') 1021 SelectionChanged: Symbol('SelectionChanged')
1016 }; 1022 };
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698