Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2877893002: Make UseCounter take a LocaFrame instead of any Frame (Closed)
Patch Set: Fix compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index a776b7476ecae707a061b2410297131216d3d9c0..3eac83c7b5c5f961eb9bb647d7f9280400bbb1f8 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -1181,14 +1181,14 @@ void UseCounter::DidCommitLoad(KURL url) {
}
}
-void UseCounter::Count(const Frame* frame, Feature feature) {
+void UseCounter::Count(const LocalFrame* frame, Feature feature) {
if (!frame)
return;
Page* page = frame->GetPage();
if (!page)
return;
- page->GetUseCounter().Count(feature);
+ page->GetUseCounter().Count(feature, frame);
}
void UseCounter::Count(const Document& document, Feature feature) {
@@ -1260,7 +1260,9 @@ void UseCounter::Count(CSSParserMode css_parser_mode, CSSPropertyID property) {
legacy_counter_.CountCSS(property);
}
-void UseCounter::Count(Feature feature) {
+void UseCounter::Count(Feature feature, const LocalFrame* source_frame) {
+ // TODO(rbyers): Report UseCounter to browser process along with page
+ // load metrics for sourceFrame crbug.com/716565
RecordMeasurement(feature);
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/loader/MixedContentChecker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698