Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2877893002: Make UseCounter take a LocaFrame instead of any Frame (Closed)
Patch Set: Fix compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/events/TouchEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index ddf537c994f4f424c3a2d46b26fcffecbcae3a3b..9e4b7b8d05840eb01fe712f5a273d164085b4dd6 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -211,7 +211,7 @@ void V8Window::postMessageMethodCustom(
LocalDOMWindow* source = CurrentDOMWindow(info.GetIsolate());
DCHECK(window);
- UseCounter::Count(window->GetFrame(), UseCounter::kWindowPostMessage);
+ UseCounter::Count(source->GetFrame(), UseCounter::kWindowPostMessage);
// If called directly by WebCore we don't have a calling context.
if (!source) {
@@ -312,7 +312,7 @@ void V8Window::namedPropertyGetterCustom(
// https://html.spec.whatwg.org/multipage/browsers.html#document-tree-child-browsing-context-name-property-set
Frame* child = frame->Tree().ScopedChild(name);
if (child) {
- UseCounter::Count(window->GetFrame(),
+ UseCounter::Count(CurrentExecutionContext(info.GetIsolate()),
UseCounter::kNamedAccessOnWindow_ChildBrowsingContext);
// step 3. Remove each browsing context from childBrowsingContexts whose
@@ -326,7 +326,7 @@ void V8Window::namedPropertyGetterCustom(
}
UseCounter::Count(
- window->GetFrame(),
+ CurrentExecutionContext(info.GetIsolate()),
UseCounter::
kNamedAccessOnWindow_ChildBrowsingContext_CrossOriginNameMismatch);
// In addition to the above spec'ed case, we return the child window
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/events/TouchEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698