Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2877793002: Make the plugin request handling async (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -94 lines) Patch
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 12 chunks +51 lines, -45 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/plugin_test.dart View 3 chunks +50 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-11 15:40:06 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-11 15:41:42 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-11 16:07:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80eec49e4048efac78635caa06d99298af1a6fbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698