Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2877783004: Removed CSSPropertyAPIShadow group property stub (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed CSSPropertyAPIShadow group property stub The CSSPropertyAPIShadow stub was intended to implement a shared API between the CSSPropertyTextShadow and CSSPropertyBoxShadow properties. This stub was added prematurely, and will in fact not be used as these properties have recently been refactored and require unique parsing logic, so they will be individually implemented as APIs in future. BUG=668012 Review-Url: https://codereview.chromium.org/2877783004 Cr-Commit-Position: refs/heads/master@{#471668} Committed: https://chromium.googlesource.com/chromium/src/+/6a1960fb48be21c84024bec173b72da40d16289d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShadow.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 30 (13 generated)
Bugs Nash
3 years, 7 months ago (2017-05-12 06:19:31 UTC) #4
Jia
On 2017/05/12 06:19:31, Bugs Nash wrote: LGTM
3 years, 7 months ago (2017-05-15 00:49:40 UTC) #7
Bugs Nash
+suzyh for owners
3 years, 7 months ago (2017-05-15 01:35:16 UTC) #9
suzyh_UTC10 (ex-contributor)
I would have expected one patch to cover both the deletion of the old stub ...
3 years, 7 months ago (2017-05-15 02:05:19 UTC) #10
Bugs Nash
On 2017/05/15 at 02:05:19, suzyh wrote: > I would have expected one patch to cover ...
3 years, 7 months ago (2017-05-15 02:44:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877783004/1
3 years, 7 months ago (2017-05-15 02:45:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/436525)
3 years, 7 months ago (2017-05-15 02:52:20 UTC) #15
suzyh_UTC10 (ex-contributor)
On 2017/05/15 at 02:44:56, bugsnash wrote: > On 2017/05/15 at 02:05:19, suzyh wrote: > > ...
3 years, 7 months ago (2017-05-15 02:54:57 UTC) #16
suzyh_UTC10 (ex-contributor)
On 2017/05/15 at 02:52:20, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
3 years, 7 months ago (2017-05-15 02:55:56 UTC) #17
Bugs Nash
On 2017/05/15 at 02:54:57, suzyh wrote: > On 2017/05/15 at 02:44:56, bugsnash wrote: > > ...
3 years, 7 months ago (2017-05-15 03:03:17 UTC) #18
Bugs Nash
On 2017/05/15 at 02:55:56, suzyh wrote: > On 2017/05/15 at 02:52:20, commit-bot wrote: > > ...
3 years, 7 months ago (2017-05-15 03:03:33 UTC) #19
Bugs Nash
3 years, 7 months ago (2017-05-15 03:05:02 UTC) #22
Bugs Nash
On 2017/05/15 at 03:05:02, Bugs Nash wrote: > +alancutter for core owners
3 years, 7 months ago (2017-05-15 03:05:13 UTC) #23
alancutter (OOO until 2018)
lgtm. We should avoid landing unused code in future until we have dependent patches that ...
3 years, 7 months ago (2017-05-15 04:29:19 UTC) #24
Bugs Nash
On 2017/05/15 at 04:29:19, alancutter wrote: > lgtm. We should avoid landing unused code in ...
3 years, 7 months ago (2017-05-15 04:32:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877783004/1
3 years, 7 months ago (2017-05-15 04:32:52 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 04:37:46 UTC) #30
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a1960fb48be21c84024bec173b7...

Powered by Google App Engine
This is Rietveld 408576698