Eliminated with_checks variable

Eliminated PolymorphicInstanceCallInstr with_checks_ field

Create static calls instead of polymorphic calls without checks

R=rmacnak@google.com, vegorov@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9a1b6c3198e3307416b3ff5ad5bc01fe91211a13

[Vyacheslav Egorov (Google), 2017-05-18 06:46:27]

Description was changed from

==========
Eliminated with_checks variable


Create static calls instead of polymorphic calls without checks

R=vegorov@google.com
BUG=
==========

to

==========
Eliminated PolymorphicInstanceCallInstr with_checks_ field

Create static calls instead of polymorphic calls without checks

R=vegorov@google.com
BUG=
==========

[Vyacheslav Egorov (Google), 2017-05-18 07:03:11]

initial round of comments.

overall the code looks nice

[Ryan FYI this is the refactoring I mentioned before - killing with_checks_]

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:1848: ZoneGrowableArray<PushArgumentInstr*>* args =
This pattern (creaet array - copy push arguments create static call) occurs
multiple times in the code base. 

Maybe make a helper, for example:

FlowGraph::ReplaceCallWithStaticCall(...)

Alternatively you can have a static method on StaticCallInstr, e.g.

// I am not sure about the name
StaticCallInstr* FromCall( ) {
}

that encapsulates most of this, and then just do:

instr->ReplaceWith(StaticCallInstr::FromCall(call, ....), ...)

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:1918: Function& target = Function::ZoneHandle(Z,
function.raw());
same pattern

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2035: ZoneGrowableArray<PushArgumentInstr*>* args =
new (Z)
same pattern

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2091: // Only one target. Replace by static call.
same pattern

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.cc:3408: ASSERT(new_target->HasSingleTarget());
similar pattern

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.cc:3441: if (FLAG_precompiled_mode) return
false;
You can check for && !complete() here to make this condition less pessimistic.

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/jit_optimize...
File runtime/vm/jit_optimizer.cc (right):

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/jit_optimize...
runtime/vm/jit_optimizer.cc:220: ASSERT(targets->HasSingleTarget());
ditto: abstract this pattern into a function

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/jit_optimize...
runtime/vm/jit_optimizer.cc:1537: ZoneGrowableArray<PushArgumentInstr*>* args =
ditto

https://codereview.chromium.org/2877713003/diff/20001/runtime/vm/jit_optimize...
runtime/vm/jit_optimizer.cc:1569: ZoneGrowableArray<PushArgumentInstr*>* args =
ditto

[Aske Simon Christensen, 2017-05-18 15:59:16]

Method to construct static call from instance call

[Aske Simon Christensen, 2017-05-18 16:02:36]

Added a method for creating a static call from an instance call.

Added the !complete() check to recognize single targets on complete calls.

[Vyacheslav Egorov (Google), 2017-05-18 16:19:35]

lgtm

https://codereview.chromium.org/2877713003/diff/40001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/2877713003/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language.h:3269: // TODO(askesc): Un-templatize when
call instructions get common superclass
We moved from TODO(username) to TODO(bug-number).

So currently recommended way to add TODO is to file a bug at http://dartbug.com
and then add a comment 

TODO(dartbug.com/<bug-number>) ...

[Aske Simon Christensen, 2017-05-18 16:25:56]

Removed TODO

[rmacnak, 2017-05-18 16:34:29]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-05-18 16:34:30]

lgtm

Much clearer, thanks!

[Aske Simon Christensen, 2017-05-19 11:37:22]

Description was changed from

==========
Eliminated PolymorphicInstanceCallInstr with_checks_ field

Create static calls instead of polymorphic calls without checks

R=vegorov@google.com
BUG=
==========

to

==========
Eliminated PolymorphicInstanceCallInstr with_checks_ field

Create static calls instead of polymorphic calls without checks

R=rmacnak@google.com, vegorov@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9a1b6c3198e3307416b3ff5ad5bc01fe91211a13
==========

[Aske Simon Christensen, 2017-05-19 11:37:23]

Committed patchset #4 (id:60001) manually as
9a1b6c3198e3307416b3ff5ad5bc01fe91211a13 (presubmit successful).