Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2877683002: Adjust types in SplayTree implementation and some strong tests to (Closed)

Created:
3 years, 7 months ago by Leaf
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust types in SplayTree implementation and some strong tests to avoid relying on fuzzy arrows. BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/ccbaabad8d701111d4820665b6f64065ae533dab

Patch Set 1 #

Patch Set 2 : Use extra default compare #

Patch Set 3 : Comments #

Patch Set 4 : Bind to variable to enable promotion #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 3 Binary file 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 2 3 3 chunks +15 lines, -3 lines 0 comments Download
M tests/corelib_strong/list_sort_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/set_test.dart View 1 2 3 3 chunks +10 lines, -5 lines 0 comments Download
M tests/corelib_strong/sort_helper.dart View 1 2 3 7 chunks +14 lines, -9 lines 2 comments Download
M tests/corelib_strong/sort_test.dart View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
3 years, 7 months ago (2017-05-11 19:25:46 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2877683002/diff/30001/tests/corelib_strong/sort_helper.dart File tests/corelib_strong/sort_helper.dart (right): https://codereview.chromium.org/2877683002/diff/30001/tests/corelib_strong/sort_helper.dart#newcode10 tests/corelib_strong/sort_helper.dart:10: = void Function(List<num>); This should just be on ...
3 years, 7 months ago (2017-05-11 22:23:36 UTC) #3
Leaf
https://codereview.chromium.org/2877683002/diff/30001/tests/corelib_strong/sort_helper.dart File tests/corelib_strong/sort_helper.dart (right): https://codereview.chromium.org/2877683002/diff/30001/tests/corelib_strong/sort_helper.dart#newcode10 tests/corelib_strong/sort_helper.dart:10: = void Function(List<num>); On 2017/05/11 22:23:36, Lasse Reichstein Nielsen ...
3 years, 7 months ago (2017-05-12 00:22:35 UTC) #4
Leaf
3 years, 7 months ago (2017-05-12 00:27:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:30001) manually as
ccbaabad8d701111d4820665b6f64065ae533dab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698