Expose UkmService to content/

content/browser/renderer_host/render_widget_host_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <vector>
@@ skipping 14 matching lines @@
 
 namespace gfx {
 class Point;
 class Size;
 }
 
 namespace rappor {
 class Sample;
 }
 
+namespace ukm {
+class UkmService;
+}
+
 namespace content {
 
 class BrowserAccessibilityManager;
 class RenderWidgetHostImpl;
 class RenderWidgetHostInputEventRouter;
 class RenderViewHostDelegateView;
 class TextInputManager;
 class WebContents;
 enum class KeyboardEventProcessingResult;
 struct ScreenInfo;
@@ skipping 188 matching lines @@
   // |render_widget_host| is focused and that its owning WebContents is also
   // the focused WebContents.
   virtual void FocusOwningWebContents(
       RenderWidgetHostImpl* render_widget_host) {}
 
   // Augment a Rappor sample with eTLD+1 context. The caller is still
   // responsible for logging the sample to the RapporService. Returns false
   // if the eTLD+1 is not known for |render_widget_host|.
   virtual bool AddDomainInfoToRapporSample(rappor::Sample* sample);
 
+  // Update UkmService for the given source with the URL. Returns false

[Charlie Reis, 2017/05/24 16:28:32]

Can you elaborate what UkmService is here?  I didn't know it was URL-keyed
metrics until I dug into the code.

[Navid Zolghadr, 2017/05/25 15:45:46]

Done.

+  // if the Utl is not known for |render_widget_host|.

[Charlie Reis, 2017/05/24 16:28:32]

What is Utl?

[Navid Zolghadr, 2017/05/25 15:45:46]

Done.

+  virtual bool UpdateUrlForUkmSource(ukm::UkmService* service,

[Charlie Reis, 2017/05/24 16:28:32]

This doesn't look like it ever returns false in practice, and the proposed call
site in RenderWidgetHostLatencyTracker::GetUkmSourceId() (in
https://codereview.chromium.org/2888153002) doesn't check the return value. 
Maybe it should just be void?

[Navid Zolghadr, 2017/05/25 15:45:46]

Done.

+                                     int32_t ukm_source_id);
+
   // Notifies the delegate that a focused editable element has been touched
   // inside this RenderWidgetHost. If |editable| is true then the focused
   // element accepts text input.
   virtual void FocusedNodeTouched(bool editable) {}
 
   // Return this object cast to a WebContents, if it is one. If the object is
   // not a WebContents, returns nullptr.
   virtual WebContents* GetAsWebContents();
 
   // Notifies that a CompositorFrame was received from the renderer.
   virtual void DidReceiveCompositorFrame() {}
 
  protected:
   virtual ~RenderWidgetHostDelegate() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_