content/browser/DEPS - Issue 2877673003: Expose UkmService to content/

Side by Side Diff: content/browser/DEPS

Issue 2877673003: Expose UkmService to content/ (Closed)

Patch Set: Extract repoting of input metric into another CL Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | content/browser/renderer_host/render_widget_host_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Allow inclusion of specific components that we depend on.	2 # Allow inclusion of specific components that we depend on.

3 # See comment in content/DEPS for which components are allowed.	3 # See comment in content/DEPS for which components are allowed.

4 "+components/discardable_memory/common",	4 "+components/discardable_memory/common",

5 "+components/discardable_memory/service",	5 "+components/discardable_memory/service",

6 "+components/display_compositor",	6 "+components/display_compositor",

7 "+components/filesystem",	7 "+components/filesystem",

8 "+components/leveldb",	8 "+components/leveldb",

9 "+components/link_header_util",	9 "+components/link_header_util",

10 "+components/metrics",	10 "+components/metrics",

11 "+components/metrics:single_sample_metrics",	11 "+components/metrics:single_sample_metrics",

12 "+components/mime_util",	12 "+components/mime_util",

13 "+components/payments",	13 "+components/payments",

14 "+components/profile_service",	14 "+components/profile_service",

15 "+components/rappor/public",	15 "+components/rappor/public",

16 "+components/scheduler/common",	16 "+components/scheduler/common",

17 "+components/tracing",	17 "+components/tracing",

	18 "+components/ukm",
	Charlie Reis 2017/05/24 16:28:31 Nick and I have concerns that other content embedd Nick and I have concerns that other content embedders may not want to depend on this entire component. Would it be possible to do something like components/rappor/public where content just depends on an interface that an embedder can stub out if desired? Navid Zolghadr 2017/05/24 16:41:54 I knew that was coming. :) I did that rappor/publi Show quoted text On 2017/05/24 16:28:31, Charlie Reis wrote: > Nick and I have concerns that other content embedders may not want to depend on > this entire component. Would it be possible to do something like > components/rappor/public where content just depends on an interface that an > embedder can stub out if desired? I knew that was coming. :) I did that rappor/public myself as well. I'll start doing it. That'll take a while. Charlie Reis 2017/05/24 16:46:24 Heh, apologies for the extra work, but I think it' Show quoted text On 2017/05/24 16:41:54, Navid Zolghadr wrote: > On 2017/05/24 16:28:31, Charlie Reis wrote: > > Nick and I have concerns that other content embedders may not want to depend > on > > this entire component. Would it be possible to do something like > > components/rappor/public where content just depends on an interface that an > > embedder can stub out if desired? > > I knew that was coming. :) > I did that rappor/public myself as well. I'll start doing it. That'll take a > while. Heh, apologies for the extra work, but I think it'll be worthwhile. :) Navid Zolghadr 2017/05/25 15:45:46 I didn't realized the other changed already added Show quoted text On 2017/05/24 16:46:24, Charlie Reis (overloaded) wrote: > On 2017/05/24 16:41:54, Navid Zolghadr wrote: > > On 2017/05/24 16:28:31, Charlie Reis wrote: > > > Nick and I have concerns that other content embedders may not want to depend > > on > > > this entire component. Would it be possible to do something like > > > components/rappor/public where content just depends on an interface that an > > > embedder can stub out if desired? > > > > I knew that was coming. :) > > I did that rappor/public myself as well. I'll start doing it. That'll take a > > while. > > Heh, apologies for the extra work, but I think it'll be worthwhile. :) I didn't realized the other changed already added that public folder stuff in ukm. Alright. So I just did a rebase and a few renames and it is all good now.
18 "+components/url_formatter",	19 "+components/url_formatter",

19 "+components/viz",	20 "+components/viz",

20	21

21 "+content/app/strings/grit", # For generated headers	22 "+content/app/strings/grit", # For generated headers

22 "+content/public/browser",	23 "+content/public/browser",

23 "+device/gamepad", # For gamepad API	24 "+device/gamepad", # For gamepad API

24 "+device/generic_sensor", # For sensors service.	25 "+device/generic_sensor", # For sensors service.

25 "+device/geolocation",	26 "+device/geolocation",

26 "+device/nfc",	27 "+device/nfc",

27 "+device/power_save_blocker",	28 "+device/power_save_blocker",

(...skipping 101 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
129 "+third_party/WebKit/public/web/WebSharedWorkerCreationContextType.h",	130 "+third_party/WebKit/public/web/WebSharedWorkerCreationContextType.h",

130 "+third_party/WebKit/public/web/WebSharedWorkerCreationErrors.h",	131 "+third_party/WebKit/public/web/WebSharedWorkerCreationErrors.h",

131 "+third_party/WebKit/public/web/WebTextDirection.h",	132 "+third_party/WebKit/public/web/WebTextDirection.h",

132 "+third_party/WebKit/public/web/WebTreeScopeType.h",	133 "+third_party/WebKit/public/web/WebTreeScopeType.h",

133 "+third_party/WebKit/public/web/mac/WebScrollbarTheme.h",	134 "+third_party/WebKit/public/web/mac/WebScrollbarTheme.h",

134	135

135 # DO NOT ADD ANY CHROME OR COMPONENTS INCLUDES HERE!!!	136 # DO NOT ADD ANY CHROME OR COMPONENTS INCLUDES HERE!!!

136 # See https://sites.google.com/a/chromium.org/dev/developers/content-module	137 # See https://sites.google.com/a/chromium.org/dev/developers/content-module

137 # for more information.	138 # for more information.

138 ]	139 ]

OLD	NEW