Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2377)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2877673002: Rewrite Layer::SetScrollOffset{FromImplSide} property tree fast-path (Closed)
Patch Set: Address reviewer comments with simpler "UpdateScrollOffset" fn Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index 614331c0a4794824d789d3080aa40ef23e9e8aa7..e1d590ff449f588a4c841221b6d1a74bdc712be8 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -770,6 +770,9 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, OneScrollNode) {
EXPECT_EQ(transform_node_index, transform_node.id);
EXPECT_EQ(0u, scroll_client.did_scroll_count);
+ // TODO(pdr): The PaintArtifactCompositor should set the scroll clip layer id
+ // so the Layer is scrollable. This call should be removed.
+ layer->SetScrollClipLayerId(layer->id());
layer->SetScrollOffsetFromImplSide(gfx::ScrollOffset(1, 2));
EXPECT_EQ(1u, scroll_client.did_scroll_count);
EXPECT_EQ(gfx::ScrollOffset(1, 2), scroll_client.last_scroll_offset);
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698