Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: cc/layers/layer.h

Issue 2877673002: Rewrite Layer::SetScrollOffset{FromImplSide} property tree fast-path (Closed)
Patch Set: Address reviewer comments with simpler "UpdateScrollOffset" fn Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.h
diff --git a/cc/layers/layer.h b/cc/layers/layer.h
index 581271731c5ad90510b582bc335461e999073947..938ca5edb9c3ba323dafb6f8da06ed609e2f9c98 100644
--- a/cc/layers/layer.h
+++ b/cc/layers/layer.h
@@ -505,6 +505,12 @@ class CC_EXPORT Layer : public base::RefCounted<Layer> {
// layer should own a property tree node or not.
void SetPropertyTreesNeedRebuild();
+ // Fast-path for |SetScrollOffset| and |SetScrollOffsetFromImplSide| to
+ // directly update scroll offset values in the property tree without needing a
+ // full property tree update. If property trees do not exist yet, ensures
+ // they are marked as needing to be rebuilt.
+ void UpdateScrollOffset(const gfx::ScrollOffset&);
+
// Encapsulates all data, callbacks or interfaces received from the embedder.
// TODO(khushalsagar): This is only valid when PropertyTrees are built
// internally in cc. Update this for the SPv2 path where blink generates
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698