Chromium Code Reviews| Index: pkg/analysis_server/test/domain_completion_test.dart |
| diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart |
| index e477ab2f12a1d726f1dcffd029a65d33d05e1b59..a7de5427999fc54ce6c05113d7b527ace04c6879 100644 |
| --- a/pkg/analysis_server/test/domain_completion_test.dart |
| +++ b/pkg/analysis_server/test/domain_completion_test.dart |
| @@ -275,12 +275,7 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest { |
| }); |
| } |
| - @failingTest |
| test_imports_aborted_new_request() async { |
| - // TODO(brianwilkerson) Figure out whether this test makes sense when |
| - // running the new driver. It waits for an initial empty notification then |
| - // waits for a new notification. But I think that under the driver we only |
| - // ever send one notification. |
| addTestFile(''' |
| class foo { } |
| c^'''); |
| @@ -401,6 +396,10 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest { |
| completionId = response.id; |
| assertValidId(completionId); |
| await waitForTasksFinished(); |
| + // wait for response to arrive |
| + while (replacementOffset == null) { |
|
pquitslund
2017/05/11 03:48:36
Perhaps a note explaining why this is necessary?
danrubel
2017/05/11 16:37:51
Done.
|
| + await new Future.delayed(new Duration(milliseconds: 5)); |
| + } |
| expect(replacementOffset, completionOffset - 1); |
| expect(replacementLength, 1); |
| assertHasResult(CompletionSuggestionKind.KEYWORD, 'library', |