components/content_settings/core/browser/content_settings_registry.cc - Issue 2877553002: [subresource_filter] Swap ALLOW and BLOCK meanings in the content setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry.cc

Issue 2877553002: [subresource_filter] Swap ALLOW and BLOCK meanings in the content setting (Closed)

Patch Set: fix newer tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry.cc

diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc

index 217e0a8eb282365058ac9a83f1cf7ba6543894c8..6b18f449543cacb3ce70e237a93f088ee631506d 100644

--- a/components/content_settings/core/browser/content_settings_registry.cc

+++ b/components/content_settings/core/browser/content_settings_registry.cc

@@ -275,8 +275,8 @@ void ContentSettingsRegistry::Init() {

ContentSettingsInfo::INHERIT_IF_LESS_PERMISSIVE);

- CONTENT_SETTING_ALLOW,

- WebsiteSettingsInfo::UNSYNCABLE, WhitelistedSchemes(),

+ CONTENT_SETTING_BLOCK, WebsiteSettingsInfo::UNSYNCABLE,

+ WhitelistedSchemes(),

ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK),

WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE,

WebsiteSettingsRegistry::DESKTOP |