chrome/browser/subresource_filter/subresource_filter_browsertest.cc - Issue 2877553002: [subresource_filter] Swap ALLOW and BLOCK meanings in the content setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Issue 2877553002: [subresource_filter] Swap ALLOW and BLOCK meanings in the content setting (Closed)

Patch Set: fix newer tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/subresource_filter/chrome_subresource_filter_client.cc ('k') | chrome/browser/subresource_filter/subresource_filter_content_settings_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

diff --git a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

index 0d3ea6570cf2f40d415e82ca1dbb6957d9dbde31..7fc6d156c34c4df5e9c2901da6c816948def53e1 100644

--- a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

+++ b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

@@ -939,7 +939,7 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,

HostContentSettingsMapFactory::GetForProfile(browser()->profile());

settings_map->SetContentSettingDefaultScope(

url, url, ContentSettingsType::CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER,

- std::string(), CONTENT_SETTING_BLOCK);

+ std::string(), CONTENT_SETTING_ALLOW);

ui_test_utils::NavigateToURL(browser(), url);

EXPECT_TRUE(WasParsedScriptElementLoaded(web_contents()->GetMainFrame()));

@@ -961,7 +961,7 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,

HostContentSettingsMapFactory::GetForProfile(browser()->profile());

settings_map->SetContentSettingDefaultScope(

url, url, ContentSettingsType::CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER,

- std::string(), CONTENT_SETTING_ALLOW);

+ std::string(), CONTENT_SETTING_BLOCK);

// Setting the site to "allow" should not activate filtering.

ui_test_utils::NavigateToURL(browser(), url);