third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp - Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp

Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously (Closed)

Patch Set: Address comments from falken@ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp

index b3aa4da5d83590e6461c62480be5fd65ebe31d13..4d9fad63ccb75b678d2177655b7f235932dd9094 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp

@@ -52,8 +52,14 @@ ExtendableEvent::~ExtendableEvent() {}

void ExtendableEvent::waitUntil(ScriptState* script_state,

ScriptPromise script_promise,

ExceptionState& exception_state) {

- if (observer_)

- observer_->WaitUntil(script_state, script_promise, exception_state);

+ if (!observer_) {

+ exception_state.ThrowDOMException(

+ kInvalidStateError,

+ "Can not call waitUntil on a script constructed ExtendableEvent.");

+ return;

+ }

+ observer_->WaitUntil(script_state, script_promise, exception_state);

}

ExtendableEvent::ExtendableEvent(const AtomicString& type,