third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js - Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js

Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously (Closed)

Patch Set: Address comments from falken@ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/extendable-event-async-waituntil.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js

index 3f81a544f3f02181e3d460f994b63af897902da1..974416ef6011b52bb0ea1d42a82f1694ff2ba290 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js

@@ -61,6 +61,9 @@ self.synthesizeNotificationClick = function() {

var handler = function(e) {

resolve(e);

+ // To allow waitUntil to be called inside execution of the microtask

+ // enqueued by above resolve function.

+ e.waitUntil(Promise.resolve());

e.notification.close();

self.removeEventListener('notificationclick', handler);

};