third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h - Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously (Closed)

Patch Set: Let RespondWithObserver call WaitUntilObserver::WaitUntil to add extend lifetime promise Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

index ccc03af2bd9a66914810e39c171c800dc022b055..5de7fc35ea9bc4dda7d1b8448ffad1df59ee9333 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

@@ -61,7 +61,7 @@ class MODULES_EXPORT RespondWithObserver

private:

class ThenFunction;

- void ResponseWasRejected(WebServiceWorkerResponseError);

+ void ResponseWasRejected(WebServiceWorkerResponseError, const ScriptValue&);

void ResponseWasFulfilled(const ScriptValue&);

enum State { kInitial, kPending, kDone };