third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js - Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js

Issue 2877543003: [ServiceWorker] Allow waitUntil to be called multiple times asynchronously (Closed)

Patch Set: Let RespondWithObserver call WaitUntilObserver::WaitUntil to add extend lifetime promise Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js ('k') | third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js

index 09b7724613d25acac74c9fdeed73b1c9be1ac87e..10e86d357cb69a811d90732e07f09b1b51f9d4b8 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/windowclient-navigate-worker.js

@@ -4,7 +4,13 @@ function match_query(query_string) {

function receive_event(event_name) {

return new Promise(function(resolve) {

- self.addEventListener(event_name, resolve, false);

+ var handler = function(e) {

+ resolve(e);

+ // To allow waitUntil to be called inside execution of the microtask

+ // enqueued by above resolve function.

+ e.waitUntil(Promise.resolve());

+ };

+ self.addEventListener(event_name, handler, false);

});

}