Implements core logic for Pixel Canvas

ui/gfx/canvas.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_CANVAS_H_
 #define UI_GFX_CANVAS_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 173 matching lines @@
 
   // Returns true if the current clip is empty.
   bool IsClipEmpty() const;
 
   // Returns the bounds of the current clip (in local coordinates) in the
   // |bounds| parameter, and returns true if it is non empty.
   bool GetClipBounds(Rect* bounds);
 
   void Translate(const Vector2d& offset);
 
-  void Scale(int x_scale, int y_scale);
+  void Scale(float x_scale, float y_scale);

[oshima, 2017/06/15 22:59:13]

Can you land this fix separately?

[malaykeshav, 2017/06/16 20:41:58]

This is required only for Pixel canvas to scale with fractional values. I think
it should go along with this change.

[oshima, 2017/06/17 00:55:45]

I mean this isn't just a bug that we need to fix anyway?

 
   // Fills the entire canvas' bitmap (restricted to current clip) with
   // specified |color| using a transfer mode of SkBlendMode::kSrcOver.
   void DrawColor(SkColor color);
 
   // Fills the entire canvas' bitmap (restricted to current clip) with
   // specified |color| and |mode|.
   void DrawColor(SkColor color, SkBlendMode mode);
 
   // Fills |rect| with |color| using a transfer mode of
@@ skipping 261 matching lines @@
   base::Optional<SkBitmap> bitmap_;
   base::Optional<cc::SkiaPaintCanvas> owned_canvas_;
   cc::PaintCanvas* canvas_;
 
   DISALLOW_COPY_AND_ASSIGN(Canvas);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_CANVAS_H_