third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp - Issue 2877273002: Image Capture: reject setOptions()/applyConstraints() if any argument is unsupported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

Issue 2877273002: Image Capture: reject setOptions()/applyConstraints() if any argument is unsupported (Closed)

Patch Set: reillyg@ comments and rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp ('K') | « third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

diff --git a/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

index 750f909a1d01faf1a9501d0698396cc257e72f1f..8bdc7fa72fa465351c7d7683758620b78fbcb78a 100644

--- a/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

+++ b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

@@ -45,6 +45,11 @@ String PhotoCapabilities::redEyeReduction() const {

return "";

}

+bool PhotoCapabilities::IsRedEyeReductionControllable() const {

+ return red_eye_reduction_ ==

+ media::mojom::blink::RedEyeReduction::CONTROLLABLE;

DEFINE_TRACE(PhotoCapabilities) {

visitor->Trace(image_height_);

visitor->Trace(image_width_);