Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/ast_factory.dart

Issue 2877253003: Don't type promote local functions. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:front_end/src/fasta/scanner.dart' show Token; 5 import 'package:front_end/src/fasta/scanner.dart' show Token;
6 import 'package:front_end/src/fasta/type_inference/type_promotion.dart'; 6 import 'package:front_end/src/fasta/type_inference/type_promotion.dart';
7 import 'package:kernel/ast.dart'; 7 import 'package:kernel/ast.dart';
8 8
9 /// An abstract class containing factory methods that create AST objects. 9 /// An abstract class containing factory methods that create AST objects.
10 /// 10 ///
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 /// kernel, which desugars each variable declaration to its own statement. 182 /// kernel, which desugars each variable declaration to its own statement.
183 /// 183 ///
184 /// If the variable declaration did not have an explicitly declared type, 184 /// If the variable declaration did not have an explicitly declared type,
185 /// [type] should be `null`. 185 /// [type] should be `null`.
186 VariableDeclaration variableDeclaration( 186 VariableDeclaration variableDeclaration(
187 String name, Token token, int functionNestingLevel, 187 String name, Token token, int functionNestingLevel,
188 {DartType type, 188 {DartType type,
189 Expression initializer, 189 Expression initializer,
190 Token equalsToken, 190 Token equalsToken,
191 bool isFinal: false, 191 bool isFinal: false,
192 bool isConst: false}); 192 bool isConst: false,
193 bool isLocalFunction: false});
193 194
194 /// Creates a read of a local variable. 195 /// Creates a read of a local variable.
195 VariableGet variableGet(VariableDeclaration variable, 196 VariableGet variableGet(VariableDeclaration variable,
196 TypePromotionFact<V> fact, TypePromotionScope scope, Token token); 197 TypePromotionFact<V> fact, TypePromotionScope scope, Token token);
197 198
198 /// Creates a write of a local variable. 199 /// Creates a write of a local variable.
199 VariableSet variableSet(VariableDeclaration variable, Expression value); 200 VariableSet variableSet(VariableDeclaration variable, Expression value);
200 } 201 }
OLDNEW
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698