Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: components/feature_engagement_tracker/internal/model_impl.cc

Issue 2877243002: Support IPH NotifyEvent calls before Initialize (Closed)
Patch Set: Fixed build.gn Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feature_engagement_tracker/internal/model_impl.cc
diff --git a/components/feature_engagement_tracker/internal/model_impl.cc b/components/feature_engagement_tracker/internal/model_impl.cc
index 9badfe3e7ad7f90291beb0f5d760b86e6ab1cc83..beced53d3f3fd894f408c2e90e4ac1bb87e39ff5 100644
--- a/components/feature_engagement_tracker/internal/model_impl.cc
+++ b/components/feature_engagement_tracker/internal/model_impl.cc
@@ -50,7 +50,6 @@ const Event* ModelImpl::GetEvent(const std::string& event_name) const {
void ModelImpl::IncrementEvent(const std::string& event_name,
uint32_t current_day) {
- // TODO(nyquist): Add support for pending events.
// TODO(nyquist): Track this event in UMA.
DCHECK(ready_);
@@ -81,8 +80,7 @@ void ModelImpl::OnStoreLoaded(const OnModelInitializationFinished& callback,
bool success,
std::unique_ptr<std::vector<Event>> events) {
if (!success) {
- base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
- base::Bind(callback, false));
+ callback.Run(false);
return;
}
@@ -116,9 +114,7 @@ void ModelImpl::OnStoreLoaded(const OnModelInitializationFinished& callback,
}
ready_ = true;
-
- base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
- base::Bind(callback, true));
+ callback.Run(true);
}
Event& ModelImpl::GetNonConstEvent(const std::string& event_name) {

Powered by Google App Engine
This is Rietveld 408576698