Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc

Issue 2877243002: Support IPH NotifyEvent calls before Initialize (Closed)
Patch Set: Fixed build.gn Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
diff --git a/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc b/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
index e5427267fc5d67515bee382e27abcae1718bc2b2..f17775ba8d7110cd8b97fb958f5715c7f85a98bf 100644
--- a/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
+++ b/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
@@ -13,6 +13,7 @@
#include "base/run_loop.h"
#include "components/feature_engagement_tracker/internal/editable_configuration.h"
#include "components/feature_engagement_tracker/internal/in_memory_store.h"
+#include "components/feature_engagement_tracker/internal/model_impl.h"
#include "components/feature_engagement_tracker/internal/never_storage_validator.h"
#include "components/feature_engagement_tracker/internal/once_condition_validator.h"
#include "components/feature_engagement_tracker/internal/time_provider.h"
@@ -103,10 +104,12 @@ class FeatureEngagementTrackerImplTest : public ::testing::Test {
RegisterFeatureConfig(configuration.get(), kTestFeatureBar, true);
RegisterFeatureConfig(configuration.get(), kTestFeatureQux, false);
+ auto model = base::MakeUnique<ModelImpl>(
+ CreateStore(), base::MakeUnique<NeverStorageValidator>());
+
tracker_.reset(new FeatureEngagementTrackerImpl(
- CreateStore(), std::move(configuration),
+ std::move(model), std::move(configuration),
base::MakeUnique<OnceConditionValidator>(),
- base::MakeUnique<NeverStorageValidator>(),
base::MakeUnique<TestTimeProvider>()));
}

Powered by Google App Engine
This is Rietveld 408576698