Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: pkg/front_end/test/subpackage_relationships_test.dart

Issue 2877193003: Start actually adding incrementality into incremental kernel generator. (Closed)
Patch Set: Fixes for review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/dependency_grapher.dart'; 9 import 'package:front_end/dependency_grapher.dart';
10 import 'package:path/path.dart' as pathos; 10 import 'package:path/path.dart' as pathos;
(...skipping 10 matching lines...) Expand all
21 /// 21 ///
22 /// TODO(paulberry): stuff in lib/src shouldn't depend on lib; lib should just 22 /// TODO(paulberry): stuff in lib/src shouldn't depend on lib; lib should just
23 /// re-export stuff in lib/src. 23 /// re-export stuff in lib/src.
24 /// TODO(paulberry): remove dependencies on analyzer. 24 /// TODO(paulberry): remove dependencies on analyzer.
25 final subpackageRules = { 25 final subpackageRules = {
26 'lib': new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 26 'lib': new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
27 'lib/src', 27 'lib/src',
28 'lib/src/base', 28 'lib/src/base',
29 'lib/src/fasta', 29 'lib/src/fasta',
30 'lib/src/fasta/dill', 30 'lib/src/fasta/dill',
31 'lib/src/fasta/kernel' 31 'lib/src/fasta/kernel',
32 'lib/src/incremental'
32 ]), 33 ]),
33 'lib/src': new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 34 'lib/src': new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
34 'lib', 35 'lib',
35 'lib/src/base', 36 'lib/src/base',
36 'lib/src/fasta', 37 'lib/src/fasta',
37 "lib/src/fasta/dill", 38 "lib/src/fasta/dill",
38 "lib/src/fasta/kernel", 39 "lib/src/fasta/kernel",
39 'lib/src/fasta/source', 40 'lib/src/fasta/source',
40 'lib/src/incremental', 41 'lib/src/incremental',
41 ]), 42 ]),
42 'lib/src/base': new SubpackageRules( 43 'lib/src/base': new SubpackageRules(
43 mayImportAnalyzer: true, allowedDependencies: ['lib', "lib/src/fasta"]), 44 mayImportAnalyzer: true,
45 allowedDependencies: ['lib', "lib/src/fasta", 'lib/src/incremental']),
44 'lib/src/codegen': new SubpackageRules(), 46 'lib/src/codegen': new SubpackageRules(),
45 'lib/src/fasta': new SubpackageRules(allowedDependencies: [ 47 'lib/src/fasta': new SubpackageRules(allowedDependencies: [
46 'lib', 48 'lib',
47 'lib/src/fasta/builder', 49 'lib/src/fasta/builder',
48 'lib/src/fasta/dill', 50 'lib/src/fasta/dill',
49 'lib/src/fasta/kernel', 51 'lib/src/fasta/kernel',
50 'lib/src/fasta/parser', 52 'lib/src/fasta/parser',
51 'lib/src/fasta/scanner', 53 'lib/src/fasta/scanner',
52 'lib/src/fasta/testing', 54 'lib/src/fasta/testing',
53 'lib/src/fasta/util', 55 'lib/src/fasta/util',
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 if (subpackageRules[subpackage].allowSubdirs) { 287 if (subpackageRules[subpackage].allowSubdirs) {
286 subpackageRules[subpackage].actuallyHasSubdirs = true; 288 subpackageRules[subpackage].actuallyHasSubdirs = true;
287 } else { 289 } else {
288 problem('Uri $src is in a subfolder of $subpackage, but that ' 290 problem('Uri $src is in a subfolder of $subpackage, but that '
289 'subpackage does not allow dart files in subdirectories.'); 291 'subpackage does not allow dart files in subdirectories.');
290 } 292 }
291 } 293 }
292 return subpackage; 294 return subpackage;
293 } 295 }
294 } 296 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698