Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager.h

Issue 2877133002: VR: Add a loading indicator to the scene. (Closed)
Patch Set: Add units to timeout constant. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_manager.h
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager.h b/chrome/browser/android/vr_shell/ui_scene_manager.h
index 5f97776282041bc2dd710092a21cf79dcd5b265f..0408af20536f73e3962471e7e06e5e964ed5a2b7 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager.h
+++ b/chrome/browser/android/vr_shell/ui_scene_manager.h
@@ -15,6 +15,7 @@ class GURL;
namespace vr_shell {
+class LoadingIndicator;
class UiElement;
class UiScene;
class UrlBar;
@@ -37,7 +38,7 @@ class UiSceneManager {
// These methods are currently stubbed.
void SetSecurityLevel(int level);
void SetLoading(bool loading);
- void SetLoadProgress(double progress);
+ void SetLoadProgress(float progress);
void SetHistoryButtonsEnabled(bool can_go_back, bool can_go_forward);
void OnAppButtonClicked();
@@ -49,6 +50,7 @@ class UiSceneManager {
void CreateBackground();
void CreateUrlBar();
+ void ConfigureScene();
void ConfigureSecurityWarnings();
void OnSecurityWarningTimer();
void OnBackButtonClicked();
@@ -62,6 +64,7 @@ class UiSceneManager {
UiElement* transient_security_warning_ = nullptr;
UiElement* main_content_ = nullptr;
UrlBar* url_bar_ = nullptr;
+ LoadingIndicator* loading_indicator_ = nullptr;
bool in_cct_;
bool web_vr_mode_;

Powered by Google App Engine
This is Rietveld 408576698