Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2877053002: Relax the character limits before resorting to eTLD+1 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_platform_bridge_mac.mm
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm
index 0cf42092190e69cab13c60048e17494499f52bf8..89f88188c811efbb386b2d33042e7d55b29f6846 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm
@@ -147,11 +147,8 @@ base::string16 CreateNotificationContext(const Notification& notification,
// These numbers have been obtained through experimentation on various
// Mac OS platforms.
- // Corresponds to the string "mmmmmmmmmmmmmm"
- constexpr size_t kMaxDomainLenghtAlert = 14;
-
- // Corresponds to the string "mmmmmmmmmmmmmmmmmmmmm"
- constexpr size_t kMaxDomainLenghtBanner = 21;
+ constexpr size_t kMaxDomainLenghtAlert = 19;
+ constexpr size_t kMaxDomainLenghtBanner = 28;
size_t max_characters = IsPersistentNotification(notification)
? kMaxDomainLenghtAlert
« no previous file with comments | « no previous file | chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698