Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2877043002: Add third-party cookie blocking tests for Worker (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, blink-reviews, serviceworker-reviews, tyoshino (SeeGerritForStatus)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add third-party cookie blocking tests for Worker While implementing off-main-thread fetch (crbug.com/443374), I noticed that there is no tests for third-party cookie blocking for Worker. BUG=443374 Review-Url: https://codereview.chromium.org/2877043002 Cr-Commit-Position: refs/heads/master@{#471690} Committed: https://chromium.googlesource.com/chromium/src/+/5893160c627b1b9e36c451ce7542c76254b844d6

Patch Set 1 #

Total comments: 10

Patch Set 2 : incorporated falken's comment #

Messages

Total messages: 18 (13 generated)
horo
falken@ Could you please review this?
3 years, 7 months ago (2017-05-12 05:38:14 UTC) #5
falken
lgtm super-nit but the double negative of "blocking disabled" is a bit hard to read... ...
3 years, 7 months ago (2017-05-15 02:13:48 UTC) #8
horo
Thank you https://codereview.chromium.org/2877043002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-worker.html File third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-worker.html (right): https://codereview.chromium.org/2877043002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-worker.html#newcode1 third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-worker.html:1: <!DOCTYPE html> On 2017/05/15 02:13:48, falken wrote: ...
3 years, 7 months ago (2017-05-15 06:18:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877043002/40001
3 years, 7 months ago (2017-05-15 06:18:58 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 07:44:58 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5893160c627b1b9e36c451ce7542...

Powered by Google App Engine
This is Rietveld 408576698