Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp

Issue 2877033002: Fix cc scrollbar layer issues with initialization, and use element ids throughout. (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
index eb27f48b164067978908c2909661bfcb7ab2074e..a4dfdf425f2be3b0049e0a4a6be8c678095f5022 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
@@ -93,21 +93,21 @@ void ScrollState::ConsumeDeltaNative(double x, double y) {
}
Element* ScrollState::CurrentNativeScrollingElement() const {
- DOMNodeId dom_node_id = DomNodeIdFromCompositorElementId(
- data_->current_native_scrolling_element());
+ uint64_t dom_node_id =
+ IdFromCompositorElementId(data_->current_native_scrolling_element());
if (dom_node_id == kInvalidDOMNodeId)
return nullptr;
return ElementForId(dom_node_id);
}
void ScrollState::SetCurrentNativeScrollingElement(Element* element) {
- data_->set_current_native_scrolling_element(CreateCompositorElementId(
- DOMNodeIds::IdForNode(element), CompositorSubElementId::kScroll));
+ data_->set_current_native_scrolling_element(CompositorElementIdFromDOMNodeId(
+ DOMNodeIds::IdForNode(element), CompositorElementIdNamespace::kScroll));
}
void ScrollState::SetCurrentNativeScrollingElementById(int element_id) {
- data_->set_current_native_scrolling_element(
- CreateCompositorElementId(element_id, CompositorSubElementId::kScroll));
+ data_->set_current_native_scrolling_element(CompositorElementIdFromDOMNodeId(
+ element_id, CompositorElementIdNamespace::kScroll));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698