Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2877033002: Fix cc scrollbar layer issues with initialization, and use element ids throughout. (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
index ca181cfe9f1aa74df2c787577f55ffbc745a4bf0..ff790dd32ebc892e319f4116a7653a8f53ece639 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
@@ -2246,9 +2246,10 @@ void CompositedLayerMapping::UpdateElementIdAndCompositorMutableProperties() {
element_id = DOMNodeIds::IdForNode(owning_node);
CompositorElementId compositor_element_id;
- if (element_id)
- compositor_element_id =
- CreateCompositorElementId(element_id, CompositorSubElementId::kPrimary);
+ if (element_id) {
+ compositor_element_id = CompositorElementIdFromDOMNodeId(
+ element_id, CompositorElementIdNamespace::kPrimary);
+ }
graphics_layer_->SetElementId(compositor_element_id);
graphics_layer_->SetCompositorMutableProperties(primary_mutable_properties);
@@ -2372,10 +2373,12 @@ bool CompositedLayerMapping::UpdateScrollingLayers(
scrolling_contents_layer_ =
CreateGraphicsLayer(kCompositingReasonLayerForScrollingContents);
- if (Node* owning_node = owning_layer_.GetLayoutObject().GetNode())
+ if (Node* owning_node = owning_layer_.GetLayoutObject().GetNode()) {
scrolling_contents_layer_->SetElementId(
- CreateCompositorElementId(DOMNodeIds::IdForNode(owning_node),
- CompositorSubElementId::kScroll));
+ CompositorElementIdFromDOMNodeId(
+ DOMNodeIds::IdForNode(owning_node),
+ CompositorElementIdNamespace::kScroll));
+ }
scrolling_layer_->AddChild(scrolling_contents_layer_.get());

Powered by Google App Engine
This is Rietveld 408576698