Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp

Issue 2877033002: Fix cc scrollbar layer issues with initialization, and use element ids throughout. (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/CompositorMutableStateProvider.h" 5 #include "platform/graphics/CompositorMutableStateProvider.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "cc/layers/layer_impl.h" 8 #include "cc/layers/layer_impl.h"
9 #include "cc/trees/layer_tree_impl.h" 9 #include "cc/trees/layer_tree_impl.h"
10 #include "platform/graphics/CompositorElementId.h" 10 #include "platform/graphics/CompositorElementId.h"
11 #include "platform/graphics/CompositorMutableProperties.h" 11 #include "platform/graphics/CompositorMutableProperties.h"
12 #include "platform/graphics/CompositorMutableState.h" 12 #include "platform/graphics/CompositorMutableState.h"
13 #include "platform/graphics/CompositorMutation.h" 13 #include "platform/graphics/CompositorMutation.h"
14 #include "platform/wtf/PtrUtil.h" 14 #include "platform/wtf/PtrUtil.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 CompositorMutableStateProvider::CompositorMutableStateProvider( 18 CompositorMutableStateProvider::CompositorMutableStateProvider(
19 cc::LayerTreeImpl* tree_impl, 19 cc::LayerTreeImpl* tree_impl,
20 CompositorMutations* mutations) 20 CompositorMutations* mutations)
21 : tree_(tree_impl), mutations_(mutations) {} 21 : tree_(tree_impl), mutations_(mutations) {}
22 22
23 CompositorMutableStateProvider::~CompositorMutableStateProvider() {} 23 CompositorMutableStateProvider::~CompositorMutableStateProvider() {}
24 24
25 std::unique_ptr<CompositorMutableState> 25 std::unique_ptr<CompositorMutableState>
26 CompositorMutableStateProvider::GetMutableStateFor(uint64_t element_id) { 26 CompositorMutableStateProvider::GetMutableStateFor(uint64_t element_id) {
27 cc::LayerImpl* main_layer = tree_->LayerByElementId( 27 cc::LayerImpl* main_layer =
28 CreateCompositorElementId(element_id, CompositorSubElementId::kPrimary)); 28 tree_->LayerByElementId(CompositorElementIdFromDOMNodeId(
29 cc::LayerImpl* scroll_layer = tree_->LayerByElementId( 29 element_id, CompositorElementIdNamespace::kPrimary));
30 CreateCompositorElementId(element_id, CompositorSubElementId::kScroll)); 30 cc::LayerImpl* scroll_layer =
31 tree_->LayerByElementId(CompositorElementIdFromDOMNodeId(
32 element_id, CompositorElementIdNamespace::kScroll));
31 33
32 if (!main_layer && !scroll_layer) 34 if (!main_layer && !scroll_layer)
33 return nullptr; 35 return nullptr;
34 36
35 // Ensure that we have an entry in the map for |elementId| but do as few 37 // Ensure that we have an entry in the map for |elementId| but do as few
36 // allocations and queries as possible. This will update the map only if we 38 // allocations and queries as possible. This will update the map only if we
37 // have not added a value for |elementId|. 39 // have not added a value for |elementId|.
38 auto result = mutations_->map.insert(element_id, nullptr); 40 auto result = mutations_->map.insert(element_id, nullptr);
39 41
40 // Only if this is a new entry do we want to allocate a new mutation. 42 // Only if this is a new entry do we want to allocate a new mutation.
41 if (result.is_new_entry) 43 if (result.is_new_entry)
42 result.stored_value->value = WTF::WrapUnique(new CompositorMutation); 44 result.stored_value->value = WTF::WrapUnique(new CompositorMutation);
43 45
44 return WTF::WrapUnique(new CompositorMutableState( 46 return WTF::WrapUnique(new CompositorMutableState(
45 result.stored_value->value.get(), main_layer, scroll_layer)); 47 result.stored_value->value.get(), main_layer, scroll_layer));
46 } 48 }
47 49
48 } // namespace blink 50 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698