Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2876983002: DevTools: group by frame, not product in the network panel. (Closed)
Patch Set: review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index d1fab849ab28dfbf7166d9dfe1003d1171dd5802..2d14c927f43f2ce9f99c5ec51dd5dd99f96e5af2 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -32,9 +32,6 @@ Network.NetworkLogViewColumns = class {
this._waterfallRequestsAreStale = false;
this._waterfallScrollerWidthIsStale = true;
- /** @type {?ProductRegistry.Registry} */
- this._productRegistryInstance = null;
-
/** @type {!Components.Linkifier} */
this._popupLinkifier = new Components.Linkifier();
@@ -79,14 +76,6 @@ Network.NetworkLogViewColumns = class {
_setupDataGrid() {
var defaultColumns = Network.NetworkLogViewColumns._defaultColumns;
- if (Runtime.experiments.isEnabled('networkGroupingRequests')) {
- defaultColumns.splice(1, 0, /** @type {!Network.NetworkLogViewColumns.Descriptor} */ ({
- id: 'product',
- title: Common.UIString('Product'),
- visible: true
- }));
- }
-
var defaultColumnConfig = Network.NetworkLogViewColumns._defaultColumnConfig;
this._columns = /** @type {!Array<!Network.NetworkLogViewColumns.Descriptor>} */ ([]);
@@ -288,17 +277,6 @@ Network.NetworkLogViewColumns = class {
this._dataGrid.sortNodes(sortFunction, !this._dataGrid.isSortOrderAscending());
this._networkLogView.dataGridSorted();
return;
- } else if (columnId === 'product' && !this._productRegistryInstance) {
- ProductRegistry.instance().then(productRegistry => {
- this._productRegistryInstance = productRegistry;
- var columnConfig = this._columns.find(columnConfig => columnConfig.id === columnId);
- if (!columnConfig)
- return;
- columnConfig.sortingFunction = Network.NetworkRequestNode.ProductComparator.bind(null, productRegistry);
- if (this._dataGrid.sortColumnId() === 'product')
- this._sortHandler();
- });
- return;
}
this._waterfallColumnSortIcon.setIconType('');
@@ -554,16 +532,7 @@ Network.NetworkLogViewColumns = class {
if (!hoveredNode)
return null;
- var anchor = event.target.enclosingNodeOrSelfWithClass('product-column');
- if (anchor) {
- return {
- box: anchor.boxInWindow(),
- show: hoveredNode.handleProductPopover.bind(hoveredNode),
- hide: this._popupLinkifier.reset.bind(this._popupLinkifier)
- };
- }
-
- anchor = event.target.enclosingNodeOrSelfWithClass('network-script-initiated');
+ var anchor = event.target.enclosingNodeOrSelfWithClass('network-script-initiated');
if (!anchor)
return null;
var request = hoveredNode.request();
@@ -629,8 +598,6 @@ Network.NetworkLogViewColumns = class {
};
Network.NetworkLogViewColumns._initialSortColumn = 'waterfall';
-/** @type {?ProductRegistry.Registry} */
-Network.NetworkRequestNode._productRegistryInstance = null;
/**
* @typedef {{

Powered by Google App Engine
This is Rietveld 408576698