Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

Issue 2876983002: DevTools: group by frame, not product in the network panel. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
index 3b9d69dfb954bb970ca5722823cf0da2d625cb32..b293c420df7a3b6855c9aadfba973c437577c4de 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
@@ -67,6 +67,19 @@ Network.FrameGroupNode = class extends Network.NetworkGroupNode {
this._productInfoEntryCache;
}
+ /**
+ * @param {!UI.PopoverRequest} popover
+ * @return {!Promise<boolean>}
+ */
+ handleProductPopover(popover) {
+ var entryInfo = this._innerProductEntry();
+ if (!entryInfo)
+ return Promise.resolve(false);
+ popover.setAnchorBehavior(UI.GlassPane.AnchorBehavior.PreferBottom);
+ popover.contentElement.appendChild(Network.NetworkNode.buildReportLinkElement(entryInfo));
+ return Promise.resolve(true);
+ }
+
/**
* @override
* @return {boolean}
@@ -91,24 +104,8 @@ Network.FrameGroupNode = class extends Network.NetworkGroupNode {
*/
renderCell(cell, columnId) {
super.renderCell(cell, columnId);
- if (columnId === 'name') {
- var name = this.displayName();
- cell.textContent = name;
- cell.title = name;
- }
- if (columnId === 'product') {
- var entryInfo = this._innerProductEntry();
- if (entryInfo)
- cell.textContent = entryInfo.entry.name;
- }
- }
-
- /**
- * @override
- * @return {!Promise<?Network.NetworkNode._ProductEntryInfo>}
- */
- productEntry() {
- return Promise.resolve(this._innerProductEntry());
+ if (columnId === 'name')
+ cell.textContent = this.displayName();
}
/**

Powered by Google App Engine
This is Rietveld 408576698