Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 2876973003: Rename *Focus*-methods of FrameSelection to clarify its public API (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/FocusController.cpp
diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp
index 7860d9bf4f2470f173efcefe9825a33bb3ca4282..217b52178ece193c1a0bd537541765afc5ff7e04 100644
--- a/third_party/WebKit/Source/core/page/FocusController.cpp
+++ b/third_party/WebKit/Source/core/page/FocusController.cpp
@@ -754,12 +754,12 @@ void FocusController::SetFocusedFrame(Frame* frame, bool notify_embedder) {
// Now that the frame is updated, fire events and update the selection focused
// states of both frames.
if (old_frame && old_frame->View()) {
- old_frame->Selection().SetFocused(false);
+ old_frame->Selection().SetFrameIsFocused(false);
old_frame->DomWindow()->DispatchEvent(Event::Create(EventTypeNames::blur));
}
if (new_frame && new_frame->View() && IsFocused()) {
- new_frame->Selection().SetFocused(true);
+ new_frame->Selection().SetFrameIsFocused(true);
new_frame->DomWindow()->DispatchEvent(Event::Create(EventTypeNames::focus));
}
@@ -869,7 +869,7 @@ void FocusController::SetFocused(bool focused) {
// m_focusedFrame might be changed by blur/focus event handlers.
if (focused_frame_ && focused_frame_->IsLocalFrame() &&
ToLocalFrame(focused_frame_.Get())->View()) {
- ToLocalFrame(focused_frame_.Get())->Selection().SetFocused(focused);
+ ToLocalFrame(focused_frame_.Get())->Selection().SetFrameIsFocused(focused);
DispatchEventsOnWindowAndFocusedElement(
ToLocalFrame(focused_frame_.Get())->GetDocument(), focused);
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.cpp ('k') | third_party/WebKit/Source/core/paint/ImagePainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698