third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp - Issue 2876973003: Rename *Focus*-methods of FrameSelection to clarify its public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

Issue 2876973003: Rename *Focus*-methods of FrameSelection to clarify its public API (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTheme.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

index ed734bc7a90b1bf542004ca2e892ca85636bc33d..a21840d98e8ed4a7c2924371bb4d999bd0fdc1a8 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

@@ -218,7 +218,7 @@ void LayoutTextControlSingleLine::CapsLockStateMayHaveChanged() {

if (LocalFrame* frame = GetDocument().GetFrame())

should_draw_caps_lock_indicator =

InputElement()->type() == InputTypeNames::password &&

- frame->Selection().IsFocusedAndActive() &&

+ frame->Selection().FrameIsFocusedAndActive() &&

GetDocument().FocusedElement() == GetNode() &&

KeyboardEventManager::CurrentCapsLockState();

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTheme.cpp » ('j') | no next file with comments »