Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2876973002: Fixed download notification crash caused by uninitialized browser process (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index 541036dd13853a5e8ced4ffaef0a182e2f112b7f..5c0249782a0cec2d7777d7486b754b247d3a8844 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -1159,14 +1159,18 @@ public class DownloadManagerService extends BroadcastReceiver implements
@Override
protected void onPostExecute(Intent intent) {
- if (intent == null || !ExternalNavigationDelegateImpl.resolveIntent(intent, true)
- || !DownloadUtils.fireOpenIntentForDownload(context, intent)
- || !hasDownloadManagerService()) {
+ boolean didLaunchIntent = intent != null
+ && ExternalNavigationDelegateImpl.resolveIntent(intent, true)
+ && DownloadUtils.fireOpenIntentForDownload(context, intent);
+
+ if (!didLaunchIntent) {
openDownloadsPage(context);
- } else {
- DownloadManagerService service =
- DownloadManagerService.getDownloadManagerService();
- service.updateLastAccessTime(downloadGuid, isOffTheRecord);
+ return;
+ }
+
+ if (didLaunchIntent && hasDownloadManagerService()) {
+ DownloadManagerService.getDownloadManagerService().updateLastAccessTime(
+ downloadGuid, isOffTheRecord);
}
}
}.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698