chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java - Issue 2876863002: [Android] Show notification for opening new tab in background of Browser Actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Issue 2876863002: [Android] Show notification for opening new tab in background of Browser Actions (Closed)

Patch Set: Update based on David's comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

index cb04284027a217f155aea137d5296af164afd0f8..e29ea05f8aa611f0054f1378f83a48e16021db49 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

@@ -56,6 +56,11 @@ public class NotificationConstants {

public static final int NOTIFICATION_ID_PHYSICAL_WEB = 3;

/**

+ * Unique identifier for Browser Actions notification.

+ */

+ public static final int NOTIFICATION_ID_BROWSER_ACTIONS = 4;

+ /**

* Unique identifier for the summary notification for downloads. Using the ID this summary was

* going to have before it was migrated here.

* TODO(dtrainor): Clean up this ID and make sure it's in line with existing id counters without