chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java - Issue 2876863002: [Android] Show notification for opening new tab in background of Browser Actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

Issue 2876863002: [Android] Show notification for opening new tab in background of Browser Actions (Closed)

Patch Set: Update based on David's comment and rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

index 312d43d4a11fc9a0c5debed7cb6bade4b1677316..b209e197f8f0942e2c733ef1ca36426dfc5c8139 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

@@ -29,7 +29,7 @@ public class NotificationUmaTracker {

private static final String TAG = "NotifsUMATracker";

@Retention(RetentionPolicy.SOURCE)

@IntDef({DOWNLOAD_FILES, DOWNLOAD_PAGES, CLOSE_INCOGNITO, CONTENT_SUGGESTION, MEDIA_CAPTURE,

- PHYSICAL_WEB, MEDIA, SITES, SYNC, SYSTEM_NOTIFICATION_TYPE_BOUNDARY})

+ PHYSICAL_WEB, MEDIA, SITES, SYNC, BROWSER_ACTIONS, SYSTEM_NOTIFICATION_TYPE_BOUNDARY})

public @interface SystemNotificationType {}

@@ -51,8 +51,9 @@ public class NotificationUmaTracker {

public static final int MEDIA = 6;

public static final int SITES = 7;

public static final int SYNC = 8;

+ public static final int BROWSER_ACTIONS = 9;

- private static final int SYSTEM_NOTIFICATION_TYPE_BOUNDARY = 9;

+ private static final int SYSTEM_NOTIFICATION_TYPE_BOUNDARY = 10;

private static final String LAST_SHOWN_NOTIFICATION_TYPE_KEY =

"NotificationUmaTracker.LastShownNotificationType";