[Android] Show notification for opening new tab in background of Browser Actions

chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.ActivityManager;
@@ skipping 33 matching lines @@
 import org.chromium.base.TraceEvent;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.library_loader.LibraryLoader;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.IntentHandler.IntentHandlerDelegate;
 import org.chromium.chrome.browser.IntentHandler.TabOpenType;
 import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
 import org.chromium.chrome.browser.bookmarks.BookmarkUtils;
+import org.chromium.chrome.browser.browseractions.BrowserActionsContextMenuItemDelegate;
 import org.chromium.chrome.browser.compositor.CompositorViewHolder;
 import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
 import org.chromium.chrome.browser.compositor.layouts.Layout;
 import org.chromium.chrome.browser.compositor.layouts.LayoutManager;
 import org.chromium.chrome.browser.compositor.layouts.LayoutManagerChrome;
 import org.chromium.chrome.browser.compositor.layouts.LayoutManagerChromePhone;
 import org.chromium.chrome.browser.compositor.layouts.LayoutManagerChromeTablet;
 import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior.OverviewModeObserver;
 import org.chromium.chrome.browser.compositor.layouts.phone.StackLayout;
 import org.chromium.chrome.browser.cookies.CookiesFetcher;
@@ skipping 517 matching lines @@
 
     @Override
     public void onStart() {
         super.onStart();
         StartupMetrics.getInstance().updateIntent(getIntent());
     }
 
     @Override
     public void onStartWithNative() {
         super.onStartWithNative();
-        // If we don't have a current tab, show the overview mode.
-        if (getActivityTab() == null) mLayoutManager.showOverview(false);
+        setInitialOverviewState();
+        BrowserActionsContextMenuItemDelegate.cancelBrowserActionsNotification();
 
         resetSavedInstanceState();
     }
 
     @Override
     public void onNewIntentWithNative(Intent intent) {
         try {
             TraceEvent.begin("ChromeTabbedActivity.onNewIntentWithNative");
 
             super.onNewIntentWithNative(intent);
@@ skipping 33 matching lines @@
 
     private void handleDebugIntent(Intent intent) {
         if (ACTION_CLOSE_TABS.equals(intent.getAction())) {
             getTabModelSelector().closeAllTabs();
         } else if (MemoryPressureListener.handleDebugIntent(ChromeTabbedActivity.this,
                 intent.getAction())) {
             // Handled.
         }
     }
 
+    private boolean isStartedByBrowserActions() {

[Yusuf, 2017/05/30 17:57:15]

would look much nicer if this was a static in BrowserActions package somewhere.
maybe in the BrowserActionsActivity? or the menu item delegate itself.

[ltian, 2017/05/30 19:19:49]

Done.

+        if (BrowserActionsContextMenuItemDelegate.ACTION_BROWSER_ACTIONS_OPEN_IN_BACKGROUND.equals(
+                    getIntent().getAction())) {
+            return true;
+        }
+        return false;
+    }
+
+    private void setInitialOverviewState() {
+        boolean isOverviewVisible = mLayoutManager.overviewVisible();
+        if (getActivityTab() == null && !isOverviewVisible) {
+            toggleOverview();
+        }
+
+        boolean fromBrowserActions = isStartedByBrowserActions();
+        boolean isSingleUrl = IntentUtils.safeGetBooleanExtra(
+                getIntent(), BrowserActionsContextMenuItemDelegate.EXTRA_IS_SINGLE_URL, false);
+        if (fromBrowserActions) {
+            if (isSingleUrl == isOverviewVisible) {

[Yusuf, 2017/05/30 17:57:15]

all this logic is specific to BrowserActions and should live there as static.

[ltian, 2017/05/30 19:19:49]

Done.

+                toggleOverview();
+            }
+        }
+    }
+
     private void initializeUI() {
         try {
             TraceEvent.begin("ChromeTabbedActivity.initializeUI");
 
             CompositorViewHolder compositorViewHolder = getCompositorViewHolder();
             if (DeviceFormFactor.isTablet()) {
                 mLayoutManager = new LayoutManagerChromeTablet(compositorViewHolder);
             } else {
                 mLayoutManager = new LayoutManagerChromePhone(compositorViewHolder);
             }
@@ skipping 1120 matching lines @@
                     null,
                     intent);
         } else {
             return getTabCreator(false).launchUrlFromExternalApp(url, referer, headers,
                     externalAppId, forceNewTab, intent, mIntentHandlingTimeMs);
         }
     }
 
     private void toggleOverview() {
         Tab currentTab = getActivityTab();
+        // If we don't have a current tab, show the overview mode.
+        if (currentTab == null) {
+            mLayoutManager.showOverview(false);
+            return;
+        }
         ContentViewCore contentViewCore =
                 currentTab != null ? currentTab.getContentViewCore() : null;
 
         if (!mLayoutManager.overviewVisible()) {
             getCompositorViewHolder().hideKeyboard(new Runnable() {
                 @Override
                 public void run() {
                     mLayoutManager.showOverview(true);
                 }
             });
@@ skipping 315 matching lines @@
 
     private boolean shouldCreateNewTabsUsingBottomSheet() {
         if (mShouldCreateNewTabsUsingBottomSheet == null) {
             mShouldCreateNewTabsUsingBottomSheet = getBottomSheet() != null
                     && ChromeFeatureList.isEnabled(ChromeFeatureList.CHROME_HOME_NTP_REDESIGN);
         }
 
         return mShouldCreateNewTabsUsingBottomSheet;
     }
 }