Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)
Patch Set: alancutter@'s suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index aab482d8813b3d2dbf7066651129b08df4c23228..917467a8fad5890d83c6925746574d774bf8829b 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -581,16 +581,6 @@ bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
// - or the layoutObject knows how to exactly invalidate paints caused by the
// layout change instead of forced full paint invalidation.
- if (surround_data_.Get() != other.surround_data_.Get()) {
- // If our border widths change, then we need to layout. Other changes to
- // borders only necessitate a paint invalidation.
- if (!(BorderWidthEquals(BorderLeftWidth(), other.BorderLeftWidth())) ||
- !(BorderWidthEquals(BorderTopWidth(), other.BorderTopWidth())) ||
- !(BorderWidthEquals(BorderBottomWidth(), other.BorderBottomWidth())) ||
- !(BorderWidthEquals(BorderRightWidth(), other.BorderRightWidth())))
- return true;
- }
-
if (ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(other))
return true;
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698