Generate diffs for fields in ComputedStyle that use their public getters

third_party/WebKit/Source/core/style/ComputedStyle.cpp

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 56d1acbf7857b734517687b151f9fe8a33157107..1b0139e49fd93a1541e1d6720d0d00eba6e4624b 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -586,16 +586,6 @@ bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
   // - or the layoutObject knows how to exactly invalidate paints caused by the
   //   layout change instead of forced full paint invalidation.
 
-  if (surround_data_.Get() != other.surround_data_.Get()) {
-    // If our border widths change, then we need to layout. Other changes to
-    // borders only necessitate a paint invalidation.
-    if (!(BorderWidthEquals(BorderLeftWidth(), other.BorderLeftWidth())) ||

[shend, 2017/05/12 06:59:17]

The generated code does == directly, instead of BorderWidthEquals which calls
WidthToFixedPoint. Is there a change in behaviour here?

[nainar, 2017/05/12 07:07:47]

So I checked before I landed my CL splitting border-*-width the diffing was the
same as the generated code:
https://codereview.chromium.org/2861773004/diff/100001/third_party/WebKit/Sou...

-        !(BorderWidthEquals(BorderTopWidth(), other.BorderTopWidth())) ||
-        !(BorderWidthEquals(BorderBottomWidth(), other.BorderBottomWidth())) ||
-        !(BorderWidthEquals(BorderRightWidth(), other.BorderRightWidth())))
-      return true;
-  }
-
   if (ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(other))
     return true;