Generate diffs for fields in ComputedStyle that use their public getters

third_party/WebKit/Source/build/scripts/make_computed_style_base.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import math
 import sys
 
 import json5_generator
 import template_expander
@@ skipping 171 matching lines @@
         groups[field.group_name].append(field)
 
     no_group = groups.pop(None)
     subgroups = [Group(group_name, [], _reorder_fields(fields)) for group_name, fields in groups.items()]
     return Group('', subgroups=subgroups, fields=_reorder_fields(no_group))
 
 
 def _create_diff_groups_map(diff_function_inputs, root_group):
     diff_functions_map = {}
     for entry in diff_function_inputs:
-        diff_functions_map[entry['name']] = _create_diff_groups(entry['fields'], root_group)
+        diff_functions_map[entry['name']] = _create_diff_groups(entry['fields_to_diff'], entry['methods_to_diff'], root_group)
     return diff_functions_map
 
 
-def _create_diff_groups(fields_to_diff, root_group):
+def _list_field_dependencies(methods_to_diff):
+    field_dependencies = []
+    for entry in methods_to_diff:
+        field_dependencies.append(entry['field_dependencies'])
+    return field_dependencies

[alancutter (OOO until 2018), 2017/05/16 03:28:38]

This looks like it's creating a list of lists.

[nainar, 2017/05/16 03:46:13]

Fixed. 

+
+
+def _create_diff_groups(fields_to_diff, methods_to_diff, root_group):
     diff_group = DiffGroup(root_group.member_name)
+    field_dependencies = _list_field_dependencies(methods_to_diff)
     for subgroup in root_group.subgroups:
-        if any(field.property_name in fields_to_diff for field in subgroup.all_fields):
-            diff_group.subgroups.append(_create_diff_groups(fields_to_diff, subgroup))
+        if any(field.property_name in (fields_to_diff + field_dependencies) for field in subgroup.all_fields):
+            diff_group.subgroups.append(_create_diff_groups(fields_to_diff, methods_to_diff, subgroup))
     for field in root_group.fields:
         if field.property_name in fields_to_diff:
             diff_group.expressions.append(field.getter_expression)
+        for entry in methods_to_diff:
+            if field.property_name in entry['field_dependencies']:
+                diff_group.expressions.append(entry['method'])
     return diff_group
 
 
 def _create_enums(properties):
     """
     Returns an OrderedDict of enums to be generated, enum name -> [list of enum values]
     """
     enums = {}
     for property_ in properties:
         # Only generate enums for keyword properties that use the default field_type_path.
@@ skipping 217 matching lines @@
 
     @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl')
     def generate_base_computed_style_constants(self):
         return {
             'properties': self._properties,
             'enums': self._generated_enums,
         }
 
 if __name__ == '__main__':
     json5_generator.Maker(ComputedStyleBaseWriter).main()