Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)
Patch Set: Formatting merge Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies the fields we want to diff in the various diff function s 2 // This file specifies the fields we want to diff in the various diff function s
3 // in ComputedStyle. 3 // in ComputedStyle.
4 4
5 parameters: { 5 parameters: {
6 // The name parameter represents the name of the function to be created. 6 // The name parameter represents the name of the function to be created.
7 7
8 // The fields that need to be diffed. 8 // The fields that need to be diffed.
9 fields: { 9 fields: {
alancutter (OOO until 2018) 2017/05/16 00:43:56 Rename as fields_to_diff to match code and avoid c
nainar 2017/05/16 01:24:44 Done.
10 }, 10 },
11
12 // A map of expressions to diff (these can be public getters of fields or
13 // functions that use fields to determine a value).
14 map_of_expressions: {
alancutter (OOO until 2018) 2017/05/16 00:43:56 methods_to_diff: [ { name: "BorderLeftWidth"
nainar 2017/05/16 01:24:44 Done as the following: methods_to_diff: [ {
15 default: {},
16 },
11 }, 17 },
12 data: [ 18 data: [
13 { 19 {
14 name: "ScrollAnchorDisablingPropertyChanged", 20 name: "ScrollAnchorDisablingPropertyChanged",
15 fields: ["margin-top", "margin-left", "margin-right", "margin-bottom", 21 fields: ["margin-top", "margin-left", "margin-right", "margin-bottom",
16 "left", "right", "top", "bottom", "padding-top", 22 "left", "right", "top", "bottom", "padding-top",
17 "padding-left", "padding-right", "padding-bottom"] 23 "padding-left", "padding-right", "padding-bottom"]
18 }, 24 },
19 { 25 {
20 name: "DiffNeedsFullLayoutAndPaintInvalidation", 26 name: "DiffNeedsFullLayoutAndPaintInvalidation",
21 fields: ["padding-top", "padding-left", "padding-right", 27 fields: ["padding-top", "padding-left", "padding-right",
22 "padding-bottom"] 28 "padding-bottom"],
29 map_of_expressions: {"BorderLeftWidth()": "border-left-width",
30 "BorderTopWidth()": "border-top-width",
31 "BorderBottomWidth()": "border-bottom-width",
32 "BorderRightWidth()": "border-right-width"}
23 } 33 }
24 ], 34 ],
25 } 35 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698