Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)
Patch Set: shend@'s suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies the fields we want to diff in the various diff function s 2 // This file specifies the fields we want to diff in the various diff function s
3 // in ComputedStyle. 3 // in ComputedStyle.
4 4
5 parameters: { 5 parameters: {
6 // The name parameter represents the name of the function to be created. 6 // The name parameter represents the name of the function to be created.
7 7
8 // The fields that need to be diffed. 8 // The fields that need to be diffed.
9 fields: { 9 fields: {
10 }, 10 },
11
12 // A map of expressions to diff (these can be public getters of fields or
13 // functions that use fields to determine a value).
14 // Keys are the expressions to be called.
15 // Values are the fields associated with those expression.
16 // This is as one field can be associated with multiple expressions.
17 map_of_expressions: {
18 default: {},
19 },
11 }, 20 },
12 data: [ 21 data: [
13 { 22 {
14 name: "ScrollAnchorDisablingPropertyChanged", 23 name: "ScrollAnchorDisablingPropertyChanged",
15 fields: ["margin-top", "margin-left", "margin-right", "margin-bottom", 24 fields: ["margin-top", "margin-left", "margin-right", "margin-bottom",
16 "left", "right", "top", "bottom", "padding-top", 25 "left", "right", "top", "bottom", "padding-top",
17 "padding-left", "padding-right", "padding-bottom"] 26 "padding-left", "padding-right", "padding-bottom"]
18 }, 27 },
19 { 28 {
20 name: "DiffNeedsFullLayoutAndPaintInvalidation", 29 name: "DiffNeedsFullLayoutAndPaintInvalidation",
21 fields: ["padding-top", "padding-left", "padding-right", 30 fields: ["padding-top", "padding-left", "padding-right",
22 "padding-bottom"] 31 "padding-bottom"],
32 map_of_expressions: {"BorderLeftWidth()": "border-left-width",
33 "BorderTopWidth()": "border-top-width",
34 "BorderBottomWidth()": "border-bottom-width",
35 "BorderRightWidth()": "border-right-width"}
23 } 36 }
24 ], 37 ],
25 } 38 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698