Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js

Issue 2876793007: DevTools: Fix flamechart jumping on mouseout (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js
diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js
index 3ce93a82e80fcdb6344b54c6c4a65e38dc05c3be..6b674bdf855e0c6c9eb6981df0501c8a8c9a913b 100644
--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js
+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js
@@ -172,8 +172,8 @@ PerfUI.ChartViewport = class extends UI.VBox {
return false;
this._isDragging = true;
this._initMaxDragOffset(event);
- this._dragStartPointX = event.offsetX;
- this._dragStartPointY = event.offsetY;
+ this._dragStartPointX = event.pageX;
+ this._dragStartPointY = event.pageY;
this._dragStartScrollTop = this._vScrollElement.scrollTop;
this.viewportElement.style.cursor = '';
this.hideHighlight();
@@ -184,14 +184,14 @@ PerfUI.ChartViewport = class extends UI.VBox {
* @param {!MouseEvent} event
*/
_dragging(event) {
- var pixelShift = this._dragStartPointX - event.offsetX;
- this._dragStartPointX = event.offsetX;
+ var pixelShift = this._dragStartPointX - event.pageX;
+ this._dragStartPointX = event.pageX;
this._muteAnimation = true;
this._handlePanGesture(pixelShift * this._pixelToTime);
this._muteAnimation = false;
- var pixelScroll = this._dragStartPointY - event.offsetY;
+ var pixelScroll = this._dragStartPointY - event.pageY;
this._vScrollElement.scrollTop = this._dragStartScrollTop + pixelScroll;
- this._updateMaxDragOffset(event.offsetX, event.offsetY);
+ this._updateMaxDragOffset(event.pageX, event.pageY);
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698