Issue 287673002: chrome.bluetoothLowEnergy: Implement the onDescriptorValueChanged event.

Issue 287673002: chrome.bluetoothLowEnergy: Implement the onDescriptorValueChanged event. (Closed)

Created:
6 years, 7 months ago by armansito

Modified:
6 years, 7 months ago

Reviewers:
keybuk, rpaquay, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome.bluetoothLowEnergy: Implement the onDescriptorValueChanged event. This CL implements the onDescriptorValueChanged event of the bluetoothLowEnergy API. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272215

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added link to definition of GATT. #

Patch Set 3 : Rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -2 lines)			Patch
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/bluetooth_low_energy.idl	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
A +	chrome/test/data/extensions/api_test/bluetooth_low_energy/descriptor_value_changed/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/bluetooth_low_energy/descriptor_value_changed/runtest.js	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

armansito

kalman@: please rubberstamp for chrome/common/extensions/

6 years, 7 months ago (2014-05-13 20:09:05 UTC) #1

not at google - send to devlin

rubberstamp lgtm of the IDL https://codereview.chromium.org/287673002/diff/1/chrome/common/extensions/api/bluetooth_low_energy.idl File chrome/common/extensions/api/bluetooth_low_energy.idl (right): https://codereview.chromium.org/287673002/diff/1/chrome/common/extensions/api/bluetooth_low_energy.idl#newcode14 chrome/common/extensions/api/bluetooth_low_energy.idl:14: // Represents a peripheral's ...

6 years, 7 months ago (2014-05-13 20:12:30 UTC) #2

armansito

https://codereview.chromium.org/287673002/diff/1/chrome/common/extensions/api/bluetooth_low_energy.idl File chrome/common/extensions/api/bluetooth_low_energy.idl (right): https://codereview.chromium.org/287673002/diff/1/chrome/common/extensions/api/bluetooth_low_energy.idl#newcode14 chrome/common/extensions/api/bluetooth_low_energy.idl:14: // Represents a peripheral's Bluetooth GATT Service, a collection ...

6 years, 7 months ago (2014-05-14 21:49:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/287673002/40001

6 years, 7 months ago (2014-05-22 07:12:10 UTC) #6

Message was sent while issue was closed.

Change committed as 272215

Expand Messages | Collapse Messages