components/arc/ime/arc_ime_bridge_impl.h - Issue 2876693004: Implement GetTextFromRange(), GetTextRange() and GetSelectionRange() for ArcImeService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/ime/arc_ime_bridge_impl.h

Issue 2876693004: Implement GetTextFromRange(), GetTextRange() and GetSelectionRange() for ArcImeService. (Closed)

Patch Set: save surrounding text even if cursor rect is not changed Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/ime/arc_ime_bridge_impl.h

diff --git a/components/arc/ime/arc_ime_bridge_impl.h b/components/arc/ime/arc_ime_bridge_impl.h

index 548a8dacf09ccda4932d58f90ec7769cb8eea373..46faa043070886faf605a80bcf9f375a02b23131 100644

--- a/components/arc/ime/arc_ime_bridge_impl.h

+++ b/components/arc/ime/arc_ime_bridge_impl.h

@@ -46,6 +46,11 @@ class ArcImeBridgeImpl : public ArcImeBridge,

void OnCursorRectChanged(mojom::CursorRectPtr rect) override;

void OnCancelComposition() override;

void ShowImeIfNeeded() override;

+ void OnCursorRectChangedWithSurroundingText(

+ mojom::CursorRectPtr rect,

Luis Héctor Chávez 2017/05/15 15:44:27 Can you add typemappings from mojom::CursorRectPtr

yhanada 2017/05/16 10:02:12 Done.

+ mojom::TextRangePtr text_range,

+ const std::string& text_in_range,

+ mojom::TextRangePtr selection_range) override;

private:

mojo::Binding<mojom::ImeHost> binding_;